Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_appmesh_virtual_router missing options to grpc and http/2 protocols #15198

Closed
lays147 opened this issue Sep 17, 2020 · 2 comments
Closed
Labels
service/appmesh Issues and PRs that pertain to the appmesh service.

Comments

@lays147
Copy link

lays147 commented Sep 17, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.12.29

  • provider.aws v3.6.0

Affected Resource(s)

  • aws_appmesh_virtual_router

Terraform Configuration Files

resource "aws_appmesh_virtual_router" "poc" {
  name      = "poc"
  mesh_name = aws_appmesh_mesh.this.id
  spec {
    listener {
      port_mapping {
        port     = 5000
        protocol = "grpc"
      }
    }
  }
}

Debug Output

Panic Output

Expected Behavior

aws_appmesh_virtual_router should accept grpc as a protocol option.

Actual Behavior

Error: expected spec.0.listener.0.port_mapping.0.protocol to be one of [http tcp], got grpc

Steps to Reproduce

  1. Create an app mesh
  2. Create a virtual router with protocol as grpc
  3. terraform plan

Important Factoids

Virtual Router supports http/2 and grpc as protocols. This info is not in AWS docs, though
https://docs.aws.amazon.com/app-mesh/latest/userguide/virtual_routers.html

image

References

  • #0000
@ghost ghost added the service/appmesh Issues and PRs that pertain to the appmesh service. label Sep 17, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2020
@ewbankkit
Copy link
Contributor

@lays147 Thanks for raising this issue.
It has already been noticed in #10803. I'm going to close this one as a duplicate so that we can concentrate discussion in the linked issue.
Please add any additional comments there.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2020
@ghost
Copy link

ghost commented Oct 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

No branches or pull requests

2 participants