Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helper/resource: Added error when errantly checking list, map, or set attributes in TestCheckNoResourceAttr, TestCheckResourceAttr, and TestCheckResourceAttrSet #920

Merged
merged 2 commits into from Mar 31, 2022
Merged

helper/resource: Added error when errantly checking list, map, or set attributes in TestCheckNoResourceAttr, TestCheckResourceAttr, and TestCheckResourceAttrSet #920

merged 2 commits into from Mar 31, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Mar 29, 2022

Reference: #885

@bflad
helper/resource: Added error when errantly checking list, map, or set…
1a98765 
… attributes in `TestCheckNoResourceAttr`, `TestCheckResourceAttr`, and `TestCheckResourceAttrSet`

Reference: #885
@bflad bflad added enhancement New feature or request subsystem/tests Issues and feature requests related to the testing framework. labels Mar 29, 2022
@bflad bflad added this to the v2.13.0 milestone Mar 29, 2022
@bflad bflad requested a review from a team as a code owner March 29, 2022 21:07
@bflad bflad mentioned this pull request Mar 29, 2022
Closed
detro
detro approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The fact that all the TestCheckResource* functions use an internal common sub-tester testCheckResource* makes for easily "injecting" this extra tricky verification. Clever!

@bflad bflad merged commit f74b5a6 into main Mar 31, 2022
@bflad bflad deleted the bflad-TestCheck-collection-errors branch March 31, 2022 18:34
@github-actions
Copy link

github-actions bot commented May 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@detro detro detro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request subsystem/tests Issues and feature requests related to the testing framework.
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @detro