Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helper/schema: Prevented panics during error to diagnostic conversion #914

Merged
merged 2 commits into from Mar 28, 2022
Merged

helper/schema: Prevented panics during error to diagnostic conversion #914

merged 2 commits into from Mar 28, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Mar 23, 2022

Closes #789

@bflad bflad added bug Something isn't working subsystem/diagnostics Issues and feature requests related to the diagnostics returned to core. labels Mar 23, 2022
@bflad bflad added this to the v2.13.0 milestone Mar 23, 2022
@bflad bflad requested a review from a team as a code owner March 23, 2022 19:44
detro
detro approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It makes sense not to panic but to instead report it as a warning and a "bug in the provider".

@bflad bflad merged commit ab84f8b into main Mar 28, 2022
@bflad bflad deleted the bflad-diag-empty-summary-panic branch March 28, 2022 17:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@detro detro detro approved these changes

Assignees
No one assigned
Labels
bug Something isn't working subsystem/diagnostics Issues and feature requests related to the diagnostics returned to core.
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.

Panic: Invalid diagnostic: empty summary
2 participants
@bflad @detro