Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/logger/transport.go http.RoundTripper: Ability to correlate requests/responses #545

Closed
edulop91 opened this issue Aug 24, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@edulop91
Copy link

SDK version

Master branch

Use-cases

I was spending some time debugging a performance issue with the TF Okta provider. As part of this exercise, I set the log TF_LOG level to trace. Through this code, we get nice output for request/response. Unfortunately, as far as I can tell there is no way to correlate a request with a given response in this http.RoundTripper implementation (especially in the IsDebugOrHigher branch) .

Attempted Solutions

Proposal

It would be nice to be able to add enough information to correlate a request/response pair. This could be as simple as adding a UUID that would be printed when IsDebugOrHigher for both the request and response output.

References

@edulop91 edulop91 added the enhancement New feature or request label Aug 24, 2020
@edulop91
Copy link
Author

edulop91 commented Aug 24, 2020

Github 5xx caused duplicate of #546

@ghost
Copy link

ghost commented Oct 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant