helper/resource: Skip data source states with TestStep.ImportStateCheck #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #1060 The `TestStep` type `ImportStateCheck` functionality is for verifying two specific scenarios over `ImportStateVerify`: - Resources which create multiple resources during import (an implementation detail which is an legacy anti-pattern that should no longer be present in resources). - Resources where importing may cause attributes to have syntactically different but semantically/functionally equivalent values that requires special logic to check. Terraform 1.3 and later can include data source states when importing resources. Rather than forcing provider developers to account for this Terraform version-specific behavior, the `ImportStateCheck` logic will now only receive managed resource states to match the intended usage. Previously with Terraform 1.2.9 and earlier: ``` --- PASS: TestTest_TestStep_ImportStateCheck_SkipDataSourceState (1.58s) ``` Previously with Terraform 1.3.4: ``` --- FAIL: TestTest_TestStep_ImportStateCheck_SkipDataSourceState (0.63s) /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/testing_new_import_state_test.go:16: expected 1 state, got: 2 ``` Now with Terraform 1.3.4: ``` --- PASS: TestTest_TestStep_ImportStateCheck_SkipDataSourceState (0.91s) ```
bflad
added
bug
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1060
The
TestSteptypeImportStateCheckfunctionality is for verifying two specific scenarios overImportStateVerify:Terraform 1.3 and later can include data source states when importing resources. Rather than forcing provider developers to account for this Terraform version-specific behavior, the
ImportStateChecklogic will now only receive managed resource states to match the intended usage.Previously with Terraform 1.2.9 and earlier:
Previously with Terraform 1.3.4:
Now with Terraform 1.3.4: