Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile isValidFieldName regex once #1062

Merged
merged 1 commit into from Oct 10, 2022
Merged

Compile isValidFieldName regex once #1062

merged 1 commit into from Oct 10, 2022

Conversation

skarimo
Copy link
Contributor

@skarimo skarimo commented Sep 19, 2022 •
edited

SSIA

@skarimo skarimo requested a review from a team as a code owner September 19, 2022 15:19
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 19, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

bflad
bflad approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @skarimo. 🚀 (I'm inclined to pull this in since its not exported, is generally a recommended code practice, and is in the "hot" path for attribute validation in the SDK.)

@bflad bflad added this to the v2.24.0 milestone Oct 10, 2022
@bflad bflad merged commit 3495894 into hashicorp:main Oct 10, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
technical-debt
Projects
None yet
Milestone
v2.24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skarimo @hashicorp-cla @bflad