Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ImportStatePersist to preserve state generated by import operation #1052

Merged
merged 8 commits into from Sep 8, 2022
Merged

Use ImportStatePersist to preserve state generated by import operation #1052

merged 8 commits into from Sep 8, 2022

Conversation

bendbennett
Copy link
Contributor

Closes: #717

@bendbennett
Use ImportStatePersist to preserve state generated by import operation (
6dc3fa3 
#717)
@bendbennett
Removing additional call to Init as this has already been called in r…
c8b634c 
…unNewTest and when called at this point will overwrite the contents of the .terraform directory with the current version of the provider (#717)
@bendbennett bendbennett marked this pull request as ready for review September 7, 2022 13:20
@bendbennett bendbennett requested a review from a team as a code owner September 7, 2022 13:20
@bflad
Copy link
Member

bflad commented Sep 7, 2022

@bendbennett could you also add some initial testing:

  • Inline provider with ImportState and ImportStateCheck TestStep
  • External provider with ImportState and ImportStateCheck TestStep
  • Inline provider with first TestStep ImportState and second TestStep Check
  • External provider with first TestStep ImportState and second TestStep Check

I'm having a hard sense knowing whether this looks good or not short of manually testing it. Thank you!

@bflad bflad added enhancement New feature or request subsystem/tests Issues and feature requests related to the testing framework. labels Sep 7, 2022
@bflad bflad added this to the v2.22.0 milestone Sep 7, 2022
bflad
bflad approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@bendbennett bendbennett merged commit d0009e2 into main Sep 8, 2022
@bendbennett bendbennett deleted the bendbennett/issues-717 branch September 8, 2022 06:14
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request subsystem/tests Issues and feature requests related to the testing framework.
Projects
None yet
Milestone
v2.22.0
Development

Successfully merging this pull request may close these issues.

Allow running Check tests on imported resources
2 participants
@bendbennett @bflad