Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying underlying logic behind TestStep.Taint to call the terrafom taint command #1031

Merged
merged 3 commits into from Aug 15, 2022
Merged

Modifying underlying logic behind TestStep.Taint to call the terrafom taint command #1031

merged 3 commits into from Aug 15, 2022

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Aug 12, 2022 •
edited

Closes: #1030
Closes: #625

@bendbennett bendbennett added the enhancement New feature or request label Aug 12, 2022
@bendbennett bendbennett marked this pull request as ready for review August 12, 2022 11:34
@bendbennett bendbennett requested a review from a team as a code owner August 12, 2022 11:34
bflad
bflad approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good to me 🚀

helper/resource/teststep_providers_test.go Outdated Show resolved Hide resolved
.changelog/1031.txt Outdated Show resolved Hide resolved
helper/resource/teststep_providers_test.go Outdated Show resolved Hide resolved
internal/plugintest/working_dir.go Outdated Show resolved Hide resolved
@bflad
Copy link
Member

bflad commented Aug 12, 2022

Does this also close #625?

bendbennett and others added 2 commits August 15, 2022 07:19
@bendbennett bendbennett merged commit 989becd into main Aug 15, 2022
@bendbennett bendbennett deleted the bendbennett/issues-1030 branch August 15, 2022 06:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@bendbennett @bflad