New SDKv2/logging documentation section #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurapacilio
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
I'm going to approve so I don't block this work, but I had a few questions and suggestions for you here. Overall, really great work - I think this will be very helpful for users!
Please push back on me where I've materially changed the meaning or misunderstood what's happening. Thank you for the chance to comment on this! :-)
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
detro
force-pushed
the
detro/1007-document_new-logging-http-transport
branch
from
20f6b8d
to
afe1761
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a dedicated page to the new
NewLoggingHTTPTransport()andNewSubsystemLoggingHTTPTransport()helpers, introduced in #1006.Closes #1007