.github/workflows: Use new setup-go go-version-file input

[bflad]

Reference: https://github.com/actions/setup-go/releases/tag/v3.1.0

[bflad]

Hmm. Going to debug actionlint to see if there's hardcoded information inside it and raise an issue if necessary. https://github.com/actions/setup-go/blob/v3/action.yml has the new input correctly.

[bflad]

Issue: rhysd/actionlint#139
Potential fix: rhysd/actionlint#140

[radeksimko]

FYI the new setting should also support reading .go-version - unsure if you intend to test against latest compatible version or the same version that you likely end up developing with locally (assuming you have goenv installed).

[bflad]

@radeksimko thanks for the nudge here -- I was actually looking to also remove .go-version files as part of this. I think the terraform-plugin-* projects are fine with CI/releases using the latest patch version as defined by the minor version in go.mod. I don't think anyone on the maintainers team uses goenv, but maybe that's a feature request that needs to be submitted to that project if it is not already supported functionality.

[detro]

goenv user here :)

That said, I'm not in love with the idea of a go.mod and a .go-version, but no tool seems to just read the information out of go.mod for some absurd reason.

[bflad]

Good to know, @detro! If you'd like to keep the goenv specific handling around, please reach out. It's always been a pain to keep the .go-version up to date since as far as I know, there's not a way to handle it via dependabot.

actionlint is now happy with the new actions/setup-go go-version-file input and according to the last two commits, it seems to work as expected with either go.mod or .go-version.

[detro]

The only reason I like .go-version and goenv is that we deal with a lot of repositories, and they are never going to be all in sync with the version of Go to use. So .go-version helps with that.

Otherwise I'd be glad to just rely on go.mod.

And, look: go-nv/goenv#121 - Someone we know opened that exact issue ;)

[detro]

Forgot to apply a 👍 to this, sorry

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.