tfprotov5+tfprotov6: Remove temporary ResourceServerWithMoveResourceState interface

[bflad]

terraform-plugin-go version

v0.23.0

Description

The ResourceServerWithMoveResourceState temporary interface was introduced as a way to onboard downstream SDKs onto the new MoveResourceState RPC before it was required. This enabled a period where terraform-plugin-go could support new functionality while not causing compilation errors if downstream Go modules happened to be referencing differing SDK versions that may or may not all support the new functionality immediately.

The challenge with this setup is that terraform-plugin-mux is low level enough to need to reference even the temporary interface in order to work correct. This means that while ResourceServer can require the new method, the temporary interface needs one additional release before it can removed "safely".

Proposal

In tfprotov5 and tfprotov6 remove the ResourceServerWithMoveResourceState interface type. In the changelog, note that consumers should require terraform-plugin-mux@v0.16.0 (or whatever is correct at the time) dependency to prevent compilation errors.

References

• tfprotov5+tfprotov6: Require FunctionServer in ProviderServer and MoveResourceState in ResourceServer #388