Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/logging: Use millisecond time granularity for protocol data file naming #245

Merged
merged 2 commits into from Jan 5, 2023
Merged

internal/logging: Use millisecond time granularity for protocol data file naming #245

merged 2 commits into from Jan 5, 2023

Conversation

bflad
Copy link
Member

@bflad bflad commented Jan 4, 2023

Closes #244

@bflad bflad added the bug Something isn't working label Jan 4, 2023
@bflad bflad requested a review from a team as a code owner January 4, 2023 14:47
@bflad bflad mentioned this pull request Jan 4, 2023
Closed
bendbennett
bendbennett approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v0.14.3 milestone Jan 5, 2023
@bflad bflad merged commit dcadf23 into main Jan 5, 2023
@bflad bflad deleted the bflad/data-file-overlap branch January 5, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.14.3
Development

Successfully merging this pull request may close these issues.

Protocol Data Files Overwritten
2 participants
@bflad @bendbennett