Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tftypes: Clarified ValueFromJSON error messaging with object attribute key issues #214

Merged
merged 3 commits into from Jul 28, 2022
Merged

tftypes: Clarified ValueFromJSON error messaging with object attribute key issues #214

merged 3 commits into from Jul 28, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Jul 27, 2022

Closes #211

@bflad bflad added the bug Something isn't working label Jul 27, 2022
@bflad bflad added this to the v0.13.0 milestone Jul 27, 2022
@bflad bflad requested a review from a team as a code owner July 27, 2022 13:40
bendbennett
bendbennett approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit b351d0b into main Jul 28, 2022
@bflad bflad deleted the bflad/value-json-object-error-clarifications branch July 28, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Unexpected ElementKeyValue Error Output from (tfprotov#.RawState).Unmarshal with Undefined Attributes
2 participants
@bflad @bendbennett