Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the new minimal terraform-registry-address API #200

Merged
merged 2 commits into from Jun 27, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko marked this pull request as ready for review June 23, 2022 15:47
@radeksimko radeksimko requested a review from a team as a code owner June 23, 2022 15:47
@radeksimko
Copy link
Member Author

Not sure what the CI failures are about - they look unrelated to this PR - let me know if they are, I can take a deeper look.

Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@detro
Copy link
Contributor

detro commented Jun 27, 2022

Mmm, I think the paths used when running terraform-provider-corner tests need to be updated. Let me see if I can find an example PR.

@detro
Copy link
Contributor

detro commented Jun 27, 2022

Here are the necessary changes: https://github.com/hashicorp/terraform-plugin-framework/pull/385/files. @bflad is working through a refactoring of terraform-plugin-framework, prior to 1.0, so a few repo still have to be brought up to speed.

If you want to include those changes in here, great.
Alternatively, I can open a PR to fix those and then you need to rebase: up to you @radeksimko.

@radeksimko
Copy link
Member Author

@detro I addressed the failures by adjusting the paths in the workflow file which seemed sufficient to get it all green.

PTAL

Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@bflad bflad added this to the v0.10.0 milestone Jun 27, 2022
@bflad
Copy link
Member

bflad commented Jun 27, 2022

@radeksimko are you going to cut a tagged release first or would you like these merged first? Thanks!

@radeksimko
Copy link
Member Author

@bflad I'm planning to merge all the PRs first and possibly still try to see if TF Registry itself could also consume it - which may still affect the API - but I might end up leaving that one for v2 if it gets too hairy.

@bflad bflad merged commit f21c41e into hashicorp:main Jun 27, 2022
@radeksimko radeksimko deleted the f-tfaddr-minimal-api branch June 27, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants