New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to the new minimal terraform-registry-address API #200
Conversation
1e84c15
to
a3bd3a8
Compare
a3bd3a8
to
79671a1
Compare
Not sure what the CI failures are about - they look unrelated to this PR - let me know if they are, I can take a deeper look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mmm, I think the paths used when running |
Here are the necessary changes: https://github.com/hashicorp/terraform-plugin-framework/pull/385/files. @bflad is working through a refactoring of If you want to include those changes in here, great. |
@detro I addressed the failures by adjusting the paths in the workflow file which seemed sufficient to get it all green. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
@radeksimko are you going to cut a tagged release first or would you like these merged first? Thanks! |
@bflad I'm planning to merge all the PRs first and possibly still try to see if TF Registry itself could also consume it - which may still affect the API - but I might end up leaving that one for v2 if it gets too hairy. |
Depends on hashicorp/terraform-registry-address#12