Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PlanModifyString implementation to clarify its usage #596

Closed
Integralist opened this issue Dec 19, 2022 · 3 comments
Closed

Update PlanModifyString implementation to clarify its usage #596

Integralist opened this issue Dec 19, 2022 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Integralist
Copy link
Contributor

I open a PR #595 (recently merged) that fixed an incorrect field reference and in the PR I questioned the implementation of the PlanModifyString method defined in https://github.com/hashicorp/terraform-plugin-framework/blob/main/website/docs/plugin/framework/resources/plan-modification.mdx under the heading "Creating Attribute Plan Modifiers".

@bflad mentioned...

This code example might be best served with an update to check !req.ConfigValue.IsNull() for clarity (and to allow prior plan modification to set a null plan value successfully), but it might be best to create a separate issue/PR to discuss this type of example change further.

So here I am 🙂

@Integralist Integralist added the enhancement New feature or request label Dec 19, 2022
@bflad bflad added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Dec 19, 2022
@bflad bflad added this to the v1.2.0 milestone Mar 14, 2023
@bflad
Copy link
Member

bflad commented Mar 14, 2023

@bendbennett while we are updating the plan modification page for default value support, I think this will be covered as well with those code changes. 👍

@bflad
Copy link
Member

bflad commented Mar 20, 2023

This code was updated as part of #668 and will release with terraform-plugin-framework version 1.2.0 🔜 . If there are further documentation suggestions with plan modifier handling, please raise a new issue. 👍

@bflad bflad closed this as completed Mar 20, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants