-
Notifications
You must be signed in to change notification settings - Fork 97
Improvements to Documentation #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Custom Types. | ||
--- | ||
|
||
# Custom Types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Attributes page has a "Create Provider-Defined Types and Values" section that should likely have its content moved here and then linked 👍
|
||
## Terraform Configuration and Schema | ||
|
||
### Simple Attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Framework Types and Value Types" above walks through many of these Simple/Collection configuration and schema examples although it looks like they need to be updated for schema.XXXAttribute
syntax (which I'll handle separately).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll remove these, I just thought there might be some value in being able to quickly scan the TF configuration and the schema to see the correlation for simple attributes between the two.
} | ||
``` | ||
|
||
### Nested Attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are omitted from the above sections, so it'll be good to walk through these. Do you think you could structure this new content to look more similar to the existing content (e.g. split per attribute type). Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ha, it was awkwardly on the Schemas page -- I think that content can be moved here. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have moved the content and consolidated the TF configuration and schema examples for nested attributes.
63a12a7
to
3fc33aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes: #583