Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #572 #573

Conversation

iwarapter
Copy link
Contributor

Switches from the deprecated API to the new one.

@iwarapter iwarapter requested a review from a team as a code owner December 9, 2022 22:01
@bflad bflad added this to the v1.0.0 milestone Dec 11, 2022
@bflad bflad added the breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. label Dec 11, 2022
@bflad bflad self-assigned this Dec 11, 2022
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for you for this contribution, @iwarapter! The code changes here look good for our next release, which will remove tfsdk.Schema.

If you have a second, could you also create a changelog entry by adding a .changelog/573.txt file with something like the below?

```release-note:breaking-change
resource: The `StateUpgrader` type `PriorSchema` field type has been migrated from `tfsdk.Schema` to `resource/schema.Schema`, similar to other resource schema handling
```

Otherwise, we'll handle that post-merge. Thanks again!

@bflad bflad merged commit 3413b8f into hashicorp:main Dec 12, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
@iwarapter iwarapter deleted the feat/migrate-resource-state-upgrader-to-resource-schema branch January 12, 2023 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants