Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/schema: New packages which contain type-specific schema plan modifier implementations #565

Merged
merged 2 commits into from Nov 30, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Nov 30, 2022

Reference: #132

When developers migrate from tfsdk.Schema to resource/schema.Schema, they will need to also migrate to the type-specific plan modifiers. New packages have been introduced under resource/schema, such as resource/schema/stringplanmodifier. The existing plan modifiers are deprecated, similar to the tfsdk schema handling.

Of note, the Computed handling is no longer present in any of the RequiresReplace* plan modifiers. The configuration value null check has also been moved into a separate RequiresReplaceIfConfigured plan modifier. Now the RequiresReplace plan modifier operates unconditionally, assuming the resource is being updated and there is a difference between plan and prior state values.

… modifier implementations

Reference: #132

When developers migrate from `tfsdk.Schema` to `resource/schema.Schema`, they will need to also migrate to the type-specific plan modifiers. New packages have been introduced under `resource/schema`, such as `resource/schema/stringplanmodifier`. The existing plan modifiers are deprecated, similar to the `tfsdk` schema handling.
@bflad bflad added the enhancement New feature or request label Nov 30, 2022
@bflad bflad added this to the v0.17.0 milestone Nov 30, 2022
@bflad bflad requested a review from a team as a code owner November 30, 2022 00:36
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 4db7ec6 into main Nov 30, 2022
@bflad bflad deleted the bflad/resource-schema-typeplanmodifer branch November 30, 2022 14:26
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants