Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Schema and Schema Data Related Documentation #554

Merged
merged 41 commits into from Dec 13, 2022

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Nov 28, 2022

Closes: #418
Closes: #485

@bendbennett bendbennett added the documentation Improvements or additions to documentation label Nov 30, 2022
@bflad bflad added this to the v1.0.0 milestone Dec 12, 2022
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can sneak in some Blocks page content, that'll be great, and I think this will be good to get in. 👍

website/data/plugin-framework-nav-data.json Outdated Show resolved Hide resolved
website/data/plugin-framework-nav-data.json Outdated Show resolved Hide resolved
@bendbennett bendbennett marked this pull request as ready for review December 13, 2022 08:41
@bendbennett bendbennett requested a review from a team as a code owner December 13, 2022 08:41
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🚀

}
```

## Blocks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a followup PR, I think we should just include a quick summary here similar to the top of the blocks page, then link to that page for the rest. 👍


The following examples use a resource but the same schema attribute and block types are also defined with the schema for providers and data sources. The examples focus on type-related information, the `Optional` field is included just to provide working examples but refer to Schema (add link) for information about the other fields that can be defined within attributes and blocks.

## Attributes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly in a followup for these, it might make sense to summarize that attributes set values and provide a quick table of descriptions -- leaving the nitty gritty details for the attributes page. 👍

}
```

## Custom Types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a followup change, since this is a framework-defined concept and not a Terraform one, I'd suggest moving this to its own new page. 👍


## Terraform Configuration

With the definitions we have for [provider server](#provider-server), [provider](#provider), [resource](#resource) and [data source](#data-source), we can run the provider by specifying configuration and executing `terraform apply`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for right now, but I'm a little worried this may give the impression that the provider developer can just create a *.tf file with the below and it'll magically work. Not sure if it is worth adding words or pointing to other documentation to mention how to wire/publish things together fully.

@bflad bflad merged commit 38a3421 into main Dec 13, 2022
@bflad bflad deleted the bendbennett/issues-418 branch December 13, 2022 18:48
@bflad bflad mentioned this pull request Dec 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
2 participants