Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfsdk: Document and clarify GetAttribute and SetAttribute further #534

Merged
merged 1 commit into from Nov 10, 2022
Merged

tfsdk: Document and clarify GetAttribute and SetAttribute further #534

merged 1 commit into from Nov 10, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Nov 10, 2022

Reference: #66
Reference: #186

Documenting existing intentions and behaviors with tfsdk.Config, tfsdk.Plan, and tfsdk.State type GetAttribute() and SetAttribute() methods.

@bflad
tfsdk: Document and clarify GetAttribute and SetAttribute further
a159c1d 
Reference: #66
Reference: #186

Documenting existing intentions and behaviors with `tfsdk.Config`, `tfsdk.Plan`, and `tfsdk.State` type `GetAttribute()` and `SetAttribute()` methods.
@bflad bflad added the documentation Improvements or additions to documentation label Nov 10, 2022
@bflad bflad added this to the v0.16.0 milestone Nov 10, 2022
@bflad bflad requested a review from a team as a code owner November 10, 2022 14:19
bendbennett
bendbennett approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 0eb939e into main Nov 10, 2022
@bflad bflad deleted the bflad/docs-clarifications branch November 10, 2022 15:35
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @bendbennett