Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attr: Add ValueType method to Type interface #497

Merged
merged 3 commits into from Sep 23, 2022
Merged

attr: Add ValueType method to Type interface #497

merged 3 commits into from Sep 23, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Sep 23, 2022 •
edited

Pending #495
Closes #496

This will allow the internal reflection package to return better error diagnostics.

@bflad bflad added enhancement New feature or request breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. types Issues and pull requests about our types abstraction and implementations. labels Sep 23, 2022
@bflad bflad added this to the v0.14.0 milestone Sep 23, 2022
@bflad bflad requested a review from a team as a code owner September 23, 2022 15:18
bflad added a commit that referenced this pull request Sep 23, 2022
@bflad
Update CHANGELOG for #497
d28e036
@bflad
attr: Add ValueType method to Type interface
f7f4091 
Reference: #496

This will allow the internal reflection package to return better error diagnostics.
@bflad
Update CHANGELOG for #497
e5d6949
bendbennett
bendbennett approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Quickest turnaround on an issue ever?!

@bflad
internal/reflect: Replace (attr.Type).String() usage in error details…
3b5077c 
… with reflect.TypeOf((attr.Type).ValueType())
@bflad
Copy link
Member Author

bflad commented Sep 23, 2022

Latest commit shows the updated error details 😄

@bflad bflad merged commit f24aeb9 into main Sep 23, 2022
@bflad bflad deleted the bflad/attr-Type-ValueType branch September 23, 2022 15:50
@matthewhartstonge matthewhartstonge mentioned this pull request Oct 5, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. enhancement New feature or request types Issues and pull requests about our types abstraction and implementations.
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

attr: Consider Adding ValueType Method to Type Interface
2 participants
@bflad @bendbennett