Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Remove DataSourceType and ResourceType types, Provider GetDataSources and GetResources methods #478

Merged
merged 4 commits into from Sep 13, 2022
Merged

provider: Remove DataSourceType and ResourceType types, Provider GetDataSources and GetResources methods #478

merged 4 commits into from Sep 13, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Sep 12, 2022 •
edited

Pending: hashicorp/terraform-provider-corner#93

Closes #441
Closes #442

Providers should use the Provider interface DataSources and Resources methods after migrating DataSourceType and ResourceType implementations into their respective datasource.DataSource and resource.Resource.

Some additional migration examples:

@bflad
provider: Remove DataSourceType and ResourceType types, Provider GetD…
184c70a 
…ataSources and GetResources methods

Reference: #441
Reference: #442

Providers should use the `Provider` interface `DataSources` and `Resources` methods after migrating `DataSourceType` and `ResourceType` implementations into their respective `datasource.DataSource` and `resource.Resource`.
@bflad bflad added the breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. label Sep 12, 2022
@bflad bflad added this to the v0.13.0 milestone Sep 12, 2022
@bflad bflad requested a review from a team as a code owner September 12, 2022 21:40
bendbennett
bendbennett approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Really like that refactoring.

@bflad bflad merged commit 46b5573 into main Sep 13, 2022
@bflad bflad deleted the bflad/remove-datasourcetype-resourcetype branch September 13, 2022 13:02
@iacabezasbaculima iacabezasbaculima mentioned this pull request Sep 22, 2022
Closed
1 task
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change.
Projects
None yet
Milestone
v0.13.0
2 participants
@bflad @bendbennett