Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfsdk: Add support for single nested mode blocks #477

Merged
merged 2 commits into from Sep 13, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Sep 12, 2022

Reference: #400

This support is required for provider developers to migrate from terraform-plugin-sdk to terraform-plugin-framework without affecting practitioner configurations or requiring state upgrades.

For example:

resource "examplecloud_thing" "example" {
  timeouts {
    create = "5m"
  }
}

Provider developers are encouraged to use single nested attributes where possible though, as Terraform's single nested mode block support has only been thoroughly tested in production with the terraform-plugin-sdk timeouts block and its associated handling.

Reference: #400

This support is required for provider developers to migrate from terraform-plugin-sdk to terraform-plugin-framework without affecting practitioner configurations or requiring state upgrades.

For example:

```terraform
resource "examplecloud_thing" "example" {
  timeouts {
    create = "5m"
  }
}
```
@bflad bflad added the enhancement New feature or request label Sep 12, 2022
@bflad bflad added this to the v0.13.0 milestone Sep 12, 2022
@bflad bflad requested a review from a team as a code owner September 12, 2022 19:07
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit f957ca7 into main Sep 13, 2022
@bflad bflad deleted the bflad/single-nested-mode-blocks branch September 13, 2022 12:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants