Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/privatestate: Handle terraform-plugin-sdk private state in NewData #452

Merged
merged 2 commits into from Aug 12, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Aug 12, 2022

Previously, errors such as these could be returned:

Error: Error Decoding Private State

          with random_password.min,
          on terraform_plugin_test.tf line 1, in resource "random_password" "min":
           1: resource "random_password" "min" {

        An error was encountered when decoding private state: illegal base64 data at
        input byte 0.

        This is always a problem with Terraform or terraform-plugin-framework. Please
        report this to the provider developer.

The new unit test case would fail with the same error prior to this fix.

…ewData

Previously, errors such as these could be returned:

```
Error: Error Decoding Private State

          with random_password.min,
          on terraform_plugin_test.tf line 1, in resource "random_password" "min":
           1: resource "random_password" "min" {

        An error was encountered when decoding private state: illegal base64 data at
        input byte 0.

        This is always a problem with Terraform or terraform-plugin-framework. Please
        report this to the provider developer.
```

The new unit test case would fail with the same error prior to this fix.
@bflad bflad added the bug Something isn't working label Aug 12, 2022
@bflad bflad requested a review from a team as a code owner August 12, 2022 16:29
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants