Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diag: Move (Diagnostics).ToTfprotov6Diagnostics() method to internal/toproto6 package #313

Merged
merged 3 commits into from May 3, 2022
Merged

diag: Move (Diagnostics).ToTfprotov6Diagnostics() method to internal/toproto6 package #313

merged 3 commits into from May 3, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented May 3, 2022

Reference: #215

@bflad bflad added breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. tech-debt Issues tracking technical debt that we're carrying. labels May 3, 2022
@bflad bflad added this to the v0.8.0 milestone May 3, 2022
@bflad bflad requested a review from a team as a code owner May 3, 2022 14:45
bendbennett
bendbennett reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 12176c9 into main May 3, 2022
@bflad bflad deleted the bflad-diagnostics-toproto6 branch May 3, 2022 15:27
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. tech-debt Issues tracking technical debt that we're carrying.
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @bendbennett