correct NewProtocol6ProviderServerWithError to match the sdkv2 defini…

[iwarapter]

…tion for ProtoV6ProviderFactories

The SDKv2 TestCase ProtoV6ProviderFactories expects a slightly different function signature, which results in test provider definitions like:

"example": func() (tfprotov6.ProviderServer, error) {
		srv, err := tfsdk.NewProtocol6ProviderServerWithError(New())
		return srv(), err
	},

https://github.com/hashicorp/terraform-plugin-sdk/blob/main/helper/resource/testing.go#L343-L348

This change aligns the function signature to work as below:

	"example": tfsdk.NewProtocol6ProviderServerWithError(New("test")),

I have done some simple integration tests with the corner provider.

[bflad]

Hey @iwarapter 👋 Thanks for catching this. That was indeed the intention here. Since this hasn't been released yet, I'm going to drop the extra changelog entry so it doesn't confuse anyone, but I really appreciate you catching this and fixing it before it was released.

Aside: I'm not sure yet, but as part of #215, we may actually move these to a separate package (along with Serve() and ServeOpts), so we can help reduce the size of tfsdk and clarify the abstractions better as we move closer to a v1.0.0.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.