New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tfsdk: Added logging for all framework handoffs to provider defined logic #300
Conversation
…ogic This will help practitioners and provider developers further understand when and where logic handoffs occur. In general, the framework and underlying terraform-plugin-go use the `DEBUG` log level for project code boundaries and major logic milestones while the `TRACE` log level is used for more lower level logic details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read your description about why using DEBUG
for these new logs instead of TRACE
: the reasoning makes sense, but I'm concerned how much more logging this is going to create.
Yes, the fact that user can filter by sub-system seems the way out of it, but... it's still a lot more logging.
I can't raise an argument against it more than "are you sure?", because codewise this LGTM.
388d6c8
to
e5b70c3
Compare
Rebased on
It is! However, I'm expecting there to be a lot more If the logging does wind up being too noisy, there are few options at any point (as I wouldn't expect too much of the log handling to be explicitly within any compatibility promises):
|
…et at beginning of GetAttribute/SetAttribute
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This will help practitioners and provider developers further understand when and where logic handoffs occur. In general, the framework and underlying terraform-plugin-go use the
DEBUG
log level for project code boundaries and major logic milestones while theTRACE
log level is used for more lower level logic details.