Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfsdk: Introduce ServeOpts Address field, deprecate Name field #296

Merged
merged 3 commits into from Apr 25, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Apr 21, 2022

Closes #295

@bflad bflad added enhancement New feature or request breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. labels Apr 21, 2022
@bflad bflad added this to the v0.7.0 milestone Apr 21, 2022
@bflad bflad requested a review from a team as a code owner April 21, 2022 14:11
@bflad bflad removed the breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. label Apr 21, 2022
@bflad bflad merged commit 6e12435 into main Apr 25, 2022
@bflad bflad deleted the bflad-ServeOpts-Address branch April 25, 2022 13:24
bflad added a commit that referenced this pull request Apr 27, 2022
Reference: #215
Reference: #294
Reference: #296

This change represents the first half of the work necessary to extract the `tfprotov6.ProviderServer` implementation and helper functions out of the `tfsdk` package and into separate packages. The `providerserver` package will be the provider developer facing functionality, while the next iteration of this refactoring will move the actual server implementation into a separate internal package. Once in that separate internal package, efforts can be made to make that code handle terraform-plugin-go type conversions "at the edge" better.
bflad added a commit that referenced this pull request Apr 28, 2022
#308)

Reference: #215
Reference: #294
Reference: #296

This change represents the first half of the work necessary to extract the `tfprotov6.ProviderServer` implementation and helper functions out of the `tfsdk` package and into separate packages. The `providerserver` package will be the provider developer facing functionality, while the next iteration of this refactoring will move the actual server implementation into a separate internal package. Once in that separate internal package, efforts can be made to make that code handle terraform-plugin-go type conversions "at the edge" better.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfsdk: Consider Deprecating ServeOpts Name Field In Preference of Address Field
3 participants