From 1dfcd3015ad28f94fa03c1275434d3aefbd39a25 Mon Sep 17 00:00:00 2001
From: Jared Baker <jar-b@users.noreply.github.com>
Date: Mon, 28 Nov 2022 16:25:19 -0500
Subject: [PATCH] test: block attributes with MarkComputedNilsAsUnknown (#555)

additional test coverage for the MarkComputedNilsAsUnknown changes
added in #552
---
 .../server_planresourcechange_test.go         | 87 +++++++++++++++++++
 1 file changed, 87 insertions(+)

diff --git a/internal/fwserver/server_planresourcechange_test.go b/internal/fwserver/server_planresourcechange_test.go
index 6dc1a9a31..c67f86ad9 100644
--- a/internal/fwserver/server_planresourcechange_test.go
+++ b/internal/fwserver/server_planresourcechange_test.go
@@ -115,6 +115,41 @@ func TestMarkComputedNilsAsUnknown(t *testing.T) {
 				Computed: true,
 			},
 		},
+		Blocks: map[string]tfsdk.Block{
+			// nil blocks should remain nil
+			"block-nil-optional-computed": {
+				Attributes: map[string]tfsdk.Attribute{
+					"string-nil": {
+						Type:     types.StringType,
+						Optional: true,
+						Computed: true,
+					},
+					"string-set": {
+						Type:     types.StringType,
+						Optional: true,
+						Computed: true,
+					},
+				},
+				NestingMode: tfsdk.BlockNestingModeSet,
+			},
+			"block-value-optional-computed": {
+				Attributes: map[string]tfsdk.Attribute{
+					// nested computed attributes should be unknown
+					"string-nil": {
+						Type:     types.StringType,
+						Optional: true,
+						Computed: true,
+					},
+					// nested non-nil computed attributes should be left alone
+					"string-set": {
+						Type:     types.StringType,
+						Optional: true,
+						Computed: true,
+					},
+				},
+				NestingMode: tfsdk.BlockNestingModeSet,
+			},
+		},
 	}
 	input := tftypes.NewValue(s.Type().TerraformType(context.Background()), map[string]tftypes.Value{
 		"string-value":                   tftypes.NewValue(tftypes.String, "hello, world"),
@@ -152,6 +187,32 @@ func TestMarkComputedNilsAsUnknown(t *testing.T) {
 			"string-nil": tftypes.NewValue(tftypes.String, nil),
 			"string-set": tftypes.NewValue(tftypes.String, "bar"),
 		}),
+		"block-nil-optional-computed": tftypes.NewValue(tftypes.Set{
+			ElementType: tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"string-nil": tftypes.String,
+					"string-set": tftypes.String,
+				},
+			},
+		}, nil),
+		"block-value-optional-computed": tftypes.NewValue(tftypes.Set{
+			ElementType: tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"string-nil": tftypes.String,
+					"string-set": tftypes.String,
+				},
+			},
+		}, []tftypes.Value{
+			tftypes.NewValue(tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"string-nil": tftypes.String,
+					"string-set": tftypes.String,
+				},
+			}, map[string]tftypes.Value{
+				"string-nil": tftypes.NewValue(tftypes.String, nil),
+				"string-set": tftypes.NewValue(tftypes.String, "bar"),
+			}),
+		}),
 	})
 	expected := tftypes.NewValue(s.Type().TerraformType(context.Background()), map[string]tftypes.Value{
 		"string-value":                   tftypes.NewValue(tftypes.String, "hello, world"),
@@ -189,6 +250,32 @@ func TestMarkComputedNilsAsUnknown(t *testing.T) {
 			"string-nil": tftypes.NewValue(tftypes.String, tftypes.UnknownValue),
 			"string-set": tftypes.NewValue(tftypes.String, "bar"),
 		}),
+		"block-nil-optional-computed": tftypes.NewValue(tftypes.Set{
+			ElementType: tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"string-nil": tftypes.String,
+					"string-set": tftypes.String,
+				},
+			},
+		}, nil),
+		"block-value-optional-computed": tftypes.NewValue(tftypes.Set{
+			ElementType: tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"string-nil": tftypes.String,
+					"string-set": tftypes.String,
+				},
+			},
+		}, []tftypes.Value{
+			tftypes.NewValue(tftypes.Object{
+				AttributeTypes: map[string]tftypes.Type{
+					"string-nil": tftypes.String,
+					"string-set": tftypes.String,
+				},
+			}, map[string]tftypes.Value{
+				"string-nil": tftypes.NewValue(tftypes.String, tftypes.UnknownValue),
+				"string-set": tftypes.NewValue(tftypes.String, "bar"),
+			}),
+		}),
 	})
 
 	got, err := tftypes.Transform(input, fwserver.MarkComputedNilsAsUnknown(context.Background(), input, s))