fix(template functions): Use function Title instead of ToTitle

[anmoel]

Use function Title instead of ToTitle to get capitalize strings instead of upper strings

Using cases.Title because the strings.Title function is deprecated and refs to cases.Title

resolves #164

[hashicorp-cla]

All committers have signed the CLA.

[detro]

Hey @anmoel - thanks for taking the time to look into this.

I think you are right (ToString() is probably not the right choice here), but your implementation I don't believe it would work.

You need to initialize a caser, doing something like:

package main

import (
	"fmt"
	"strings"

	"golang.org/x/text/cases"
	"golang.org/x/text/language"
)

func main() {
	str := "my Odly cAsed striNg"
	caser := cases.Title(language.Und)

	fmt.Println("ToLower: ", strings.ToLower(str))
	fmt.Println("ToUpper: ", strings.ToUpper(str))
	fmt.Println("ToTitle: ", strings.ToTitle(str))
	fmt.Println("Title: ", strings.Title(str))
	fmt.Println("Caser: ", caser.String(str))
}

[anmoel]

I will add a test in my branch and will check this

[anmoel]

Hi @detro,

i fixed the code and added tests for some template functions.
is there a reason why you use go cmp instead of testify/assert to compare objects in tests?

[detro]

Hey, thanks for this.

A few things to address though:

• removal of testify
• update of the CHANGELOG to add a new bugfix entry
• version should be v0.12.1
• update of the README to point at which function, with which casing, is used for the title template function

[detro]

It's a long standing position of HC to try to avoid dependency that are not required.

Please use go-cmp that is already part of the codebase for these tests.

[anmoel]

it is done

[detro]

thanks so much for those tests. Really appreciated.

[detro]

well spotted!

[detro]

Suggested change

	* cmd/tfplugindocs: Use existing Terraform CLI binary if available on PATH, otherwise download latest Terraform CLI binary (<https://github.com/hashicorp/terraform-plugin-docs/pull/124>).
	* cmd/tfplugindocs: Added `tf-version` flag for specifying Terraform CLI binary version to download, superseding the PATH lookup (<https://github.com/hashicorp/terraform-plugin-docs/pull/124>).
	* cmd/tfplugindocs: Use existing Terraform CLI binary if available on PATH, otherwise download latest Terraform CLI binary ([#124](https://github.com/hashicorp/terraform-plugin-docs/pull/124)).
	* cmd/tfplugindocs: Added `tf-version` flag for specifying Terraform CLI binary version to download, superseding the PATH lookup ([#124](https://github.com/hashicorp/terraform-plugin-docs/pull/124)).

[detro]

Suggested change

	* cmd/tfplugindocs: Swapped `.Type` and `.Name` resource and data source template fields so they correctly align (<https://github.com/hashicorp/terraform-plugin-docs/pull/44>).
	* schemamd: Switched attribute name rendering from bold text to code blocks so the Terraform Registry treats them as anchor links (<https://github.com/hashicorp/terraform-plugin-docs/pull/59>).
	* cmd/tfplugindocs: Swapped `.Type` and `.Name` resource and data source template fields so they correctly align ([#44](https://github.com/hashicorp/terraform-plugin-docs/pull/44)).
	* schemamd: Switched attribute name rendering from bold text to code blocks so the Terraform Registry treats them as anchor links ([#59](https://github.com/hashicorp/terraform-plugin-docs/pull/59)).

[detro]

Thanks for spotting those, but the format should be [#NUM](URL_to_NUM) (as you correctly used above)

[detro]

Another PR landed so I think you need to rebase and put this in the 0.13.0 section, but still under BUG FIXES.

[detro]

Left some comments and suggestions/corrections, but I think we are pretty much there.

It needs rebasing though.

[detro]

@anmoel I tried to do the rebasing locally, and it's really just about the CHANGELOG.

Once you rebase, we can merge and then I'll start the release process.

[detro]

Hi @anmoel - as I'd like to fix the bug, I'm happy to take it upon myself to import your commit locally, do the tweaks and rebasing, and open a new PR that superseeds this one.

If you can't get to it today, I'll try to do this either tomorrow or Monday at the latest.

[detro]

Superseeded by #168

Thank you so much for your fix: I have made sure your commit was correctly adjudicated.