Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Tuple support for doc generator #334

Open
1 task done
austinvalle opened this issue Jan 30, 2024 · 1 comment
Open
1 task done

Consider Tuple support for doc generator #334

austinvalle opened this issue Jan 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@austinvalle
Copy link
Member

austinvalle commented Jan 30, 2024

Terraform CLI and terraform-plugin-docs Versions

github.com/hashicorp/terraform-plugin-docs v0.18.0

Use Cases or Problem Statement

Bubbling up from this comment hashicorp/terraform-plugin-go#267 (comment) and a TODO in an error message here:

return nil, fmt.Errorf("TODO: tuples are not yet supported")

Tuple support is currently not implemented in tfplugindocs because neither SDKv2 or Plugin Framework support schema attributes as tuples. Despite this, it's still possible to write a provider that has tuple's in the schema with terraform-plugin-go.

This issue can be used to capture any interest in adding render logic for Tuples in tfplugindocs.

Proposal

TBD

How much impact is this issue causing?

Low

Additional Information

Code of Conduct

  • I agree to follow this project's Code of Conduct
@austinvalle austinvalle added the enhancement New feature or request label Jan 30, 2024
@bflad
Copy link
Member

bflad commented Jan 30, 2024

Drive-by comment: The documentation generation might need some special formatting consideration since there can be an arbitrary number of ordered element types for a tuple and usually the type Markdown is something like (List of String) for existing collection types. Also, the protocol only contains type information and nothing like descriptions for each element type, so it would also be interesting to hear if any use cases involve complex tuples that might warrant additional information and formatting (e.g. a sub-list) like objects in #333. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants