Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise key & value local references in for expression #1608

Open
6 tasks
Tracked by #368
radeksimko opened this issue Feb 5, 2024 · 0 comments
Open
6 tasks
Tracked by #368

Recognise key & value local references in for expression #1608

radeksimko opened this issue Feb 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@radeksimko
Copy link
Member

Language Server Version

v0.32.6

Problem Statement

Currently local references such as key and val inside of a "for expression" such as [for key, val in var.map: key => val] are not recognised in any context:

  • completion
  • hover
  • semantic highlighting
  • go-to-definition/references

2024-02-05 14 45 33

Attempted Solutions

No response

Proposal

  • Provide completion for declared key & value references on the RHS of :
  • Provide hover for key & value references (both LHS and RHS) to help user understand that e.g. map keys are always strings and list/tuple indexes are always numbers
  • Provide semantic tokens for key & value references (both LHS and RHS)
  • Provide go-to-definition from key & value references on the RHS of : to LHS declarations
  • Provide go-to-references from key & value references on the LHS of : to the RHS

Related LSP methods

No response

References

No response

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@radeksimko radeksimko added the enhancement New feature or request label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant