Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CircleCI with GitHub actions #67

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Replace CircleCI with GitHub actions #67

merged 2 commits into from
Feb 8, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Feb 7, 2023

While doing some feature work, I noticed that terraform-json is still using CircleCI. The integration stopped working a while ago (for known reasons), so I migrated everything to GHA.

I made some minor changes in the process:

TODO

  • Disable CircleCI integration

@dbanck dbanck marked this pull request as ready for review February 7, 2023 15:09
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use anything < 1.16 (yet), because the tests rely on ReadDir on os.File

This seems 👌🏻

We can't test Windows (yet), because of newlines

That sounds fixable, but we can do that in a separate PR later.

@radeksimko
Copy link
Member

btw. I disabled the CircleCI webhook in the repo.

@dbanck dbanck merged commit aa0e501 into main Feb 8, 2023
@dbanck dbanck deleted the c-replace-circleci branch February 8, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants