Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Default to SchemaAttribute #35

Closed
mavogel opened this issue May 17, 2021 · 3 comments
Closed

feat: add Default to SchemaAttribute #35

mavogel opened this issue May 17, 2021 · 3 comments

Comments

@mavogel
Copy link

mavogel commented May 17, 2021

link hashicorp/terraform-plugin-docs#65

@radeksimko
Copy link
Member

👋🏻 Manuel,
This library is only responsible for representing the JSON output from terraform, in this case from terraform providers schema -json.

I agree it would be useful for docs generation (and other use cases) to have some access to "default" value. However this would first have to be implemented in

This may or may not be a simple change, but discussion needs to happen about such a change between all affected projects. The best place to start may be by filing an issue in TF Core or SDK.

@mavogel
Copy link
Author

mavogel commented May 17, 2021

Thanks, Radek for the detailed explanation :) I did not know this requires touching so many other parts. For now, I can live with manually adding/copy-pasting the string to the Description to the schema until this is implemented

@radeksimko
Copy link
Member

Human representation of more complex cty.Values is one problem to solve, although not necessarily a hard one.

Either way if you end up doing something manually it would be still useful to open the issue in TF Core and mention the use cases + how you solve it today. That way we can be sure that any future changes solve your use case well.

Generally we (maintainers of terraform-json tend to follow the changelog of TF Core and reflect new changes here fairly frequently, so I'm going to close this issue as it's not actionable here in this context, but happy to add it once it is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants