Enable e2e testing against custom Terraform executable #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmoe
force-pushed
the
kmoe/custom-terraform-binary
branch
from
10f275f
to
94aea70
Compare
radeksimko
approved these changes
May 18, 2022
If the env var TFEXEC_E2ETEST_TERRAFORM_PATH is set to the path of a valid local Terraform executable, when e2e tests are run, only tests appropriate to that executable's version will be run. This involves both the runTest() and runTestVersions() codepaths, since both are used in e2e tests.
kmoe
force-pushed
the
kmoe/custom-terraform-binary
branch
from
94aea70
to
f4c3a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the env var
TFEXEC_E2ETEST_TERRAFORM_PATHis set to the path of a valid local Terraform executable, when e2e tests are run, only tests appropriate to that executable's version will be run.This involves both the
runTest()andrunTestVersions()codepaths, since both are used in e2e tests.The code here is quite awkward due to the need to support multiple codepaths. Happy to refactor more if we prefer.