Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Go 1.18; Bump github.com/zclconf/go-cty from 1.10.0 to 1.11.0 #331

Merged
merged 4 commits into from Aug 23, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 23, 2022

Bumps github.com/zclconf/go-cty from 1.10.0 to 1.11.0.

Changelog

Sourced from github.com/zclconf/go-cty's changelog.

1.11.0 (August 22, 2022)

Upgrade Notes

This release contains some changes to some aspects of the API that are either legacy or de-facto internal (from before the Go toolchain had an explicit idea of that). Any external module using these will experience these as breaking changes, but we know of no such caller and so are admitting these without a major release in the interests of not creating churn for users of the main API.

  • encoding/gob support utilities removed: we added these as a concession to HashiCorp who wanted to try to send cty values over some legacy protocols/formats used by legacy versions of HashiCorp Terraform. In the end those efforts were not successful for other reasons and so no Terraform release ever relied on this functionality.

    encoding/gob support has been burdensome due to how its unmarshaler interface is defined and so cty values and types are no longer automatically compatible with encoding/gob. Callers should instead use explicitly-implemented encodings, such as the built-in JSON and msgpack encodings or external libraries which use the public cty API to encode and decode.

  • cty now requires Go 1.18: although the main API is not yet making any use of type parameters, we've begun to adopt it in the hope of improving the maintainability of some internal details, starting with the backing implementation of set types.

    Since type parameters are not supported by earlier versions of the Go compiler, callers must upgrade to Go 1.18 before using cty v1.11.0 or later.

Other changes in this release

  • cty: Improved performance when comparing nonzero numbers to zero, by performing a relatively-cheap sign check on both numbers before falling back on the more expensive general equality implementation. (#125)
  • cty: It's now possible to use capsule types in the elements of sets. Previously cty would panic if asked to construct a value of a set type whose element type either is or contains a capsule type, but there is now explicit support for storing encapsulated values in sets and optional (but recommended) support for a custom hashing function per type in order to improve performance for sets with a large number of elements.
  • convert: Unify will no longer panic when asked to find a common base type for a tuple type and a list of unknown element type, and will instead just signal that such a unification is not possible. (#126)
  • stdlib: FlattenFunc will no longer panic if it encounters a null value of a type that would normally be subject to flattening. Instead, it will treat it in the same way as a null value of any non-flattenable type. (#129)
Commits
  • 3792a7b v1.11.0
  • f16c240 Update CHANGELOG.md
  • 4d209ea stdlib: Don't panic if flatten finds a null list/set/tuple value
  • 834994b Update CHANGELOG.md
  • 24404ad convert: Fix panic when unifying tuple element types
  • 97a685d go.mod: go get golang.org/x/text@v0.3.7
  • da78a28 Update CHANGELOG.md
  • 3c2818f cty: Optimize equality check for numbers of differing signs
  • b66d00a cty: Allow capsule types inside set values
  • 74095df set: Use type parameters for the Set, Rules, and Iterator types
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/zclconf/go-cty](https://github.com/zclconf/go-cty) from 1.10.0 to 1.11.0.
- [Release notes](https://github.com/zclconf/go-cty/releases)
- [Changelog](https://github.com/zclconf/go-cty/blob/main/CHANGELOG.md)
- [Commits](zclconf/go-cty@v1.10.0...v1.11.0)

---
updated-dependencies:
- dependency-name: github.com/zclconf/go-cty
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Auto-pinning label Aug 23, 2022
@kmoe kmoe self-assigned this Aug 23, 2022
@kmoe kmoe changed the title Bump github.com/zclconf/go-cty from 1.10.0 to 1.11.0 Require Go 1.18; Bump github.com/zclconf/go-cty from 1.10.0 to 1.11.0 Aug 23, 2022
@kmoe kmoe requested a review from radeksimko August 23, 2022 10:22
@kmoe
Copy link
Member

kmoe commented Aug 23, 2022

As discussed elsewhere, cty 1.11.0 requires Go 1.18. In accordance with our Go version support policy, the minimum Go version required by terraform-exec is also now Go 1.18. I've updated the CI config to match this.

4795942 removes legacy CircleCI convenience Docker images and updates to the new host cimg (see https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034).

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kmoe kmoe merged commit 24e3216 into main Aug 23, 2022
@kmoe kmoe deleted the dependabot/go_modules/github.com/zclconf/go-cty-1.11.0 branch August 23, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants