add tests for ForceUnlock #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmoe
force-pushed
the
kmoe/force-unlock-tests
branch
2 times, most recently
from
0d126e4
to
4ace2d4
Compare
kmoe
force-pushed
the
kmoe/force-unlock-tests
branch
from
4ace2d4
to
01c0dca
Compare
kmoe
force-pushed
the
kmoe/force-unlock-tests
branch
from
01c0dca
to
e25be3d
Compare
radeksimko
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #270.
ForceUnlock:ErrLockIdInvaliderror typeAlso, as of Terraform v0.15.0
terraform force-unlockdoes not take an optional[DIR]argument, and will error if it is supplied: https://github.com/hashicorp/terraform/blob/main/internal/command/unlock.go#L32The second commit adds compatibility code for this option.
Several other tfexec commands are missing either the compatibility code or the positional path option entirely. A later PR should make this consistent for all commands modified in hashicorp/terraform@ca23a09.