Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Consider io.Reader/Writer instead of string when input/output may be large #321

Open
kmoe opened this issue Jun 27, 2022 · 0 comments
Labels
thinking More thinking or discussion needed before deciding on a course of action.
Milestone

Comments

@kmoe
Copy link
Member

kmoe commented Jun 27, 2022

Another "consider" issue to figure out before v1.0.0, though this one is fairly well approachable via experimentation.

Certain tfexec functions take the whole state as input or return it as output, currently:

The state being sometimes returned as *tfjson.State and other times as a string, our first goal here should be to make the return type consistent.

Other functions whose return values may be very large include:

We should investigate, and preferably add tests for, the possibility that very large inputs or outputs to these functions could cause problems. Return types should be adjusted accordingly.

@kmoe kmoe added the thinking More thinking or discussion needed before deciding on a course of action. label Jun 27, 2022
@kmoe kmoe added this to the v1.0.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
thinking More thinking or discussion needed before deciding on a course of action.
Projects
None yet
Development

No branches or pull requests

1 participant