ci: Test with -race flag #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmoe
approved these changes
May 20, 2022
I think in reality they'd more likely finish much faster, especially with the default Looking at the CI now:
I'm happy to dial it down, but I also think that unless they take significantly longer to finish I'd much rather interpret this as a data point, than a hard/loud failure. I mean - the most likely correction we'd apply should this happen is bumping the timeout. If performance is what we're trying to measure here, then benchmarking seems like a much better tool than our existing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we don't reintroduce race conditions, which were recently addressed in #299
go test -racetends to take longer than without the flag, so I also pre-emptively increased the timeout for the E2E test run.