Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove direct dependency on github.com/sergi/go-diff #287

Merged
merged 2 commits into from Mar 28, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Mar 25, 2022

It was only being used for "pretty" text differences in 3 tests. It is still an indirect dependency due to hc-install.

$ go mod why -m github.com/sergi/go-diff
# github.com/sergi/go-diff
github.com/hashicorp/terraform-exec/tfexec/internal/testutil
github.com/hashicorp/hc-install/build
github.com/go-git/go-git/v5
github.com/sergi/go-diff/diffmatchpatch

It was only being used for "pretty" text differences in 3 tests. It is still an indirect dependency due to hc-install.

```console
$ go mod why -m github.com/sergi/go-diff
# github.com/sergi/go-diff
github.com/hashicorp/terraform-exec/tfexec/internal/testutil
github.com/hashicorp/hc-install/build
github.com/go-git/go-git/v5
github.com/sergi/go-diff/diffmatchpatch
```
@bflad bflad merged commit facff44 into main Mar 28, 2022
@bflad bflad deleted the bflad-remove-go-diff branch March 28, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants