Bump Go module compatibility to Go 1.17 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will match the README documentation, especially now that Go 1.18 is released. Updated via: ``` go mod edit -go=1.17 go mod tidy ```
|
For context, I was hoping that Go 1.17 module pruning might help with hashicorp/terraform-plugin-sdk#599, but unfortunately it doesn't. Still felt correct to update this though -- please let me know if you'd like any other changes done as part of this. |
radeksimko
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Thanks for the PR!
Since the motivating factor was release of Go 1.18, is it worth also to start testing against 1.18?
a430f84
Not a blocker for the PR though.
|
@radeksimko pushed up the CircleCI configuration updates, please take a look! |
|
Ah, will need to revert that as its not available yet: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will match the README documentation, especially now that Go 1.18 is released.
Updated via: