Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tfinstall package #235

Merged
merged 7 commits into from Nov 10, 2021
Merged

Remove tfinstall package #235

merged 7 commits into from Nov 10, 2021

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Nov 4, 2021

Closes #109.

We now import github.com/hashicorp/hc-install for installing Terraform versions during testing.

Goreleaser config is also removed, to signal that this is a library to be consumed by Go and does not compile to a binary.

@kmoe kmoe requested a review from radeksimko November 4, 2021 16:28
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, non-blocking - otherwise LGTM!

.goreleaser.yml Outdated Show resolved Hide resolved
github.com/sergi/go-diff v1.2.0
github.com/stretchr/testify v1.7.0
github.com/zclconf/go-cty v1.9.1
github.com/zclconf/go-cty-debug v0.0.0-20191215020915-b22d67c1ba0b
golang.org/x/crypto v0.0.0-20210421170649-83a5a9bb288b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🚀

tfexec/internal/testutil/tfcache.go Outdated Show resolved Hide resolved
tfexec/internal/testutil/tfcache.go Outdated Show resolved Hide resolved
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split out tfinstall into separate hcinstall module
2 participants