From 66fbb394bafb3644760e403c4f04ba8d1a053185 Mon Sep 17 00:00:00 2001 From: Katy Moe Date: Wed, 22 Jun 2022 17:42:52 +0100 Subject: [PATCH] explain why clean temp dir is used --- tfexec/internal/e2etest/util_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tfexec/internal/e2etest/util_test.go b/tfexec/internal/e2etest/util_test.go index 5d6c331e..54d4f335 100644 --- a/tfexec/internal/e2etest/util_test.go +++ b/tfexec/internal/e2etest/util_test.go @@ -46,6 +46,11 @@ func runTest(t *testing.T, fixtureName string, cb func(t *testing.T, tfVersion * // valid Terraform executable, only tests appropriate to that // executable's version will be run. if localBinPath := os.Getenv("TFEXEC_E2ETEST_TERRAFORM_PATH"); localBinPath != "" { + // By convention, every new Terraform struct is given a clean + // temp dir, even if we are only invoking tf.Version(). This + // prevents any possible confusion that could result from + // reusing an os.TempDir() (for example) that already contained + // Terraform files. td, err := ioutil.TempDir("", "tf") if err != nil { t.Fatalf("error creating temporary test directory: %s", err)