Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-compiled binaries for Nodejs v19 (for newly introduced node-pty dependency) #2441

Closed
ansgarm opened this issue Dec 21, 2022 · 1 comment 路 Fixed by #2478
Closed

Add pre-compiled binaries for Nodejs v19 (for newly introduced node-pty dependency) #2441

ansgarm opened this issue Dec 21, 2022 · 1 comment 路 Fixed by #2478
Labels
Milestone

Comments

@ansgarm
Copy link
Member

ansgarm commented Dec 21, 2022

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

cdktf-cli v0.15 is going to change the way the Terraform CLI is invoked when deploying infrastucture (#1955). The new implementation relies on invoking the Terraform CLI interactively using node-pty. We currently use the package node-pty-prebuilt-multiarch which includes pre-compiled binaries for the native code used by node-pty to allow installing cdktf-cli without having tooling available to compile C code.

Unfortunately node-pty-prebuilt-multiarch does not contain bindings for Nodejs v19 and we also prefer to stay in control over those binaries, which is why we forked that package.

The package node-pty-prebuilt-multiarch uses two approaches (prebuild and prebuildify) to build and ship pre-compiled binaries, whereas nowadays prebuildify apparently is the recommended way to go.

We have an open PR in our fork that switches to using only prebuildify.

This issue captures the work happening in that PR and links it to our Release Milestone 0.15 to make it visible.

Check out cdktf/node-pty-prebuilt-multiarch#5 for a list of open tasks currently missing in that PR.

References

@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
1 participant