Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Nodejs runtime from 12 to 16 #170

Merged
merged 5 commits into from Apr 8, 2022
Merged

Upgrade Nodejs runtime from 12 to 16 #170

merged 5 commits into from Apr 8, 2022

Conversation

chenrui333
Copy link
Contributor

This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)

cc @jpogran

@chenrui333
Copy link
Contributor Author

It is also desired to make a new release after this PR update.

@jpogran
Copy link
Collaborator

jpogran commented Mar 29, 2022

Thanks for working on this! It was on my list of thing to do, but hadn't gotten to it yet. I admit I'm a bit nervous with the jump from 12 to 16, so we'll have to test this a bunch before we increment the v1 tag.

@jpogran jpogran added the dependencies Pull requests that update a dependency file label Mar 29, 2022
@jpogran jpogran added this to the 1.4.0 milestone Mar 29, 2022
@jpogran jpogran self-assigned this Mar 29, 2022
@chenrui333
Copy link
Contributor Author

Thanks for working on this! It was on my list of thing to do, but hadn't gotten to it yet. I admit I'm a bit nervous with the jump from 12 to 16, so we'll have to test this a bunch before we increment the v1 tag.

I have to say, there is not much surprise that I have seen so far (ultimately it is just action runner update). :)

@chenrui333
Copy link
Contributor Author

Also, it should be a major upgrade. With the runtime pointing to node16, it would only work Actions Runners v2.285.0 or later.

@jpogran
Copy link
Collaborator

jpogran commented Mar 30, 2022

Good point. I'll create separate milestones. I think the changes so far since last release are fine for 1.4, but a 2.0 for a major runner bump is warranted.

@jpogran jpogran modified the milestones: 1.4.0, 2.0.0 Mar 30, 2022
@chenrui333
Copy link
Contributor Author

Sounds good, we can do two releases separately. 👍 😄

@ksatirli
Copy link
Member

ksatirli commented Apr 4, 2022

Hey @chenrui333 - this looks great (and tests well!)

@jpogran just released [1.4.0](https://github.com/hashicorp/setup-terraform/releases/tag/v1.4.0) - could you update the merging conflict?

@chenrui333
Copy link
Contributor Author

totally, let me refresh my PR.

@chenrui333
Copy link
Contributor Author

Any timeline to merge this PR?

@jpogran
Copy link
Collaborator

jpogran commented Apr 5, 2022

@chenrui333 I'll be reviewing the open PRs this week and determining which land in 2.0. Look towards that milestone for a delivery date this week

@magnetikonline
Copy link
Contributor

Also, it should be a major upgrade. With the runtime pointing to node16, it would only work Actions Runners v2.285.0 or later.

100% this - follows the same pattern as the actions/* GitHub authored action set.

chenrui333 and others added 5 commits April 8, 2022 08:34
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@jpogran
Copy link
Collaborator

jpogran commented Apr 8, 2022

Updating this in preparation for merge

@jpogran jpogran changed the title runtime: upgrade nodejs runtime from v12 to v16 Bump: Nodejs runtime from 12 to 16 Apr 8, 2022
@jpogran jpogran changed the title Bump: Nodejs runtime from 12 to 16 Upgrade Nodejs runtime from 12 to 16 Apr 8, 2022
@jpogran jpogran merged commit d5cbd3f into hashicorp:main Apr 8, 2022
@jpogran
Copy link
Collaborator

jpogran commented Apr 8, 2022

Thanks for the help @chenrui333 , this will go out in the 2.0 release, currently slated for 2022/04/15

@chenrui333 chenrui333 deleted the update-runtime-to-nodejs@16 branch April 11, 2022 15:15
@chenrui333
Copy link
Contributor Author

Sounds good, thanks @jpogran!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants