docs: update existing PR comments example #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jpogran
requested changes
Apr 7, 2022
There was a problem hiding this comment.
Thank you @tobiasbueschel for the contribution! I do think this is a valuable example to add, but also think it is valuable to have the prior example in addition to this one.
Can you leave the current example as is, and make your example an entirely new one underneath this? This way we take the explanation you put in the PR description inside the README and users can see the different ways you can configure this action.
tobiasbueschel
force-pushed
the
docs/pr-comments
branch
from
95ecb79
to
e7cb16d
Compare
|
@jpogran absolutely, I've just updated the PR to reflect this :) Do let me know if there's anything else I should change. Thanks |
jpogran
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all your efforts with this github action 馃憦
This PR improves the example in the documentation by ensuring that the PR comment made is updated instead of creating a new comment. I realize that in some situations a new comment is desirable, however, this PR assumes that for most use cases updating an existing comment for a PR is desirable.