Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_snapshot: do defer after os.Open succeed #519

Merged
merged 1 commit into from Sep 14, 2022
Merged

file_snapshot: do defer after os.Open succeed #519

merged 1 commit into from Sep 14, 2022

Conversation

dbadoy
Copy link
Contributor

@dbadoy dbadoy commented Aug 19, 2022

os.Open always returns nil if an error occurs.
So, it's seems better do defer after os.Open succeed.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 19, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@ncabatoff ncabatoff merged commit 24e68f8 into hashicorp:main Sep 14, 2022
@ncabatoff
Copy link
Contributor

Thanks @dbadoy , nice catch!

@dhiaayachi dhiaayachi mentioned this pull request Oct 5, 2022
Merged
This was referenced Oct 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbadoy @hashicorp-cla @ncabatoff