Make sure leadership transfer is set back to false in all cases. #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.3.4 introduced a bug that wound only call setLeadershipTransferInProgress back to false when leadership transfer to another node succeeded. In the case where it did not succeed, leadershipTransferInProgress was left set to true, breaking any callers that relied on it being set back to false after a failed leadership transfer.
|
|
dhiaayachi
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Thank you for working on this @VictorLowther.
I think this is a reasonable fix, I won't worry about the gap because it was already present before this.
I will leave this open until early next week to give others the chance to take a look, otherwise I will merge it.
|
@dhiaayachi Just touching base to see if there is an ETA for getting this merged yet. |
|
@VictorLowther sorry for the delay, I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.3.4 introduced a bug that would only call setLeadershipTransferInProgress back to false
when leadership transfer to another node succeeded. In the case where it did not succeed,
leadershipTransferInProgress was left set to true, breaking any callers that relied on it being set back
to false after a failed leadership transfer.