Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic getting logs after restoring from an older snapshot #85

Open
fahadullah opened this issue Feb 13, 2016 · 1 comment
Open

Panic getting logs after restoring from an older snapshot #85

fahadullah opened this issue Feb 13, 2016 · 1 comment
Labels
Milestone

Comments

@fahadullah
Copy link

https://gist.github.com/fahadullah/6089c60bf6c57da0143b

When we restore a snapshot, the lastApplied index is set to the snapshot index. If we can't restore from the latest snapshot, lastApplied index is set to an old value, X. As we had a successful snapshot afterwords, append log doesn't have log entries from X+1 to the last index and it panics looking up the missing entries.

I would have assumed we would move the applied index forward or fail to restart completely in this case instead of failing later.

@slackpad slackpad added the bug label Mar 29, 2016
@slackpad
Copy link
Contributor

@fahadullah thanks for opening an issue and providing a test - we will take a look at this one!

@armon armon mentioned this issue Mar 29, 2016
14 tasks
@slackpad slackpad added this to the v2 milestone Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants