New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retract directive for v1.1.3 #478
Conversation
Hm it looks like FWIW, v1.1.4 was published shortly after v1.1.3 and users fetching latest won't face any issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kisunji for adding this!!
Now That we support go 1.16
and 1.17
I think we should add linting to 1.17
as well.
I will remove the retract from the release/1.1.x branch because that one support go 1.14 we can't update it, we will need to upgrade consul 1.8 if we do so.
Hey there, |
This is a small change; I hope it can get merged with next tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We had issues
go get
-ing raft@v1.1.3 due to checksum mismatch. It turns out we created tag v1.1.3, fetched it as a module, then deleted the tag and recreated it on GitHub, which violates the assumption that modules are immutable (once fetched from Go's checksum proxies).This PR ensures that users will not accidentally add v1.1.3 as a dependency.