Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retract directive for v1.1.3 #478

Merged
merged 4 commits into from Apr 29, 2022
Merged

Add retract directive for v1.1.3 #478

merged 4 commits into from Apr 29, 2022

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Oct 13, 2021

We had issues go get-ing raft@v1.1.3 due to checksum mismatch. It turns out we created tag v1.1.3, fetched it as a module, then deleted the tag and recreated it on GitHub, which violates the assumption that modules are immutable (once fetched from Go's checksum proxies).

This PR ensures that users will not accidentally add v1.1.3 as a dependency.

@kisunji
Copy link
Contributor Author

kisunji commented Oct 13, 2021

Hm it looks like retract is incompatible with go <1.16. Is it worth bumping up the minimum go version for this fix or should we leave the problem as-is?

FWIW, v1.1.4 was published shortly after v1.1.3 and users fetching latest won't face any issues

Copy link
Contributor

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kisunji for adding this!!
Now That we support go 1.16 and 1.17 I think we should add linting to 1.17 as well.
I will remove the retract from the release/1.1.x branch because that one support go 1.14 we can't update it, we will need to upgrade consul 1.8 if we do so.

@stale
Copy link

stale bot commented Jan 9, 2022

Hey there,
We wanted to check in on this request since it has been inactive for at least 90 days.
Have you reviewed the latest godocs?
If you think this is still an important issue in the latest version of the Raft library or
its documentation please feel let us know and we'll keep it open for investigation.
If there is still no activity on this request in 30 days, we will go ahead and close it.
Thank you!

@stale stale bot added the waiting-reply label Jan 9, 2022
@kisunji
Copy link
Contributor Author

kisunji commented Jan 10, 2022

This is a small change; I hope it can get merged with next tag

@stale stale bot removed the waiting-reply label Jan 10, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kisunji kisunji merged commit 5157c19 into main Apr 29, 2022
@kisunji kisunji deleted the kisunji/retract1.13 branch April 29, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants